Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to clarify what empty / unset state events look like #471

Closed
turt2live opened this issue May 21, 2019 · 1 comment · Fixed by #987
Closed

Need to clarify what empty / unset state events look like #471

turt2live opened this issue May 21, 2019 · 1 comment · Fixed by #987
Labels
A-Client-Server Issues affecting the CS API clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@turt2live
Copy link
Member

turt2live commented May 21, 2019 •
edited
Loading

State events like m.room.avatar have required fields, however they are technically optional because removing the property does things. Or are clients expected to handle "url": "" (empty strings) as "no url" instead?
@turt2live turt2live added A-Client-Server Issues affecting the CS API spec-bug Something which is in the spec, but is wrong labels May 21, 2019
@turt2live turt2live mentioned this issue May 21, 2019
Closed
@turt2live turt2live changed the title url is required on room avatars, apparently Need to clarify what empty / unset state events look like May 29, 2019
@turt2live turt2live added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit and removed spec-bug Something which is in the spec, but is wrong labels May 29, 2019
@jplatte
Copy link
Contributor

jplatte commented Nov 23, 2020

People are running into this with Ruma. Would a PR making the url in m.room.avatar optional be accepted, or does there need to be a more general solution?

jplatte referenced this issue in ruma/ruma Nov 23, 2020
@jplatte
events: Allow the url in m.room.avatar to be null / missing
ee4280c 
This isn't allowed in any version of the spec, but it's the only way to
unset an avatar and will have to be supported in the future.

C.f. https://github.com/matrix-org/matrix-doc/issues/2006
@jplatte jplatte mentioned this issue Feb 28, 2022
Merged
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@jplatte jplatte mentioned this issue Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Client-Server Issues affecting the CS API clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove required attribute from m.room.avatar url jplatte/matrix-spec
2 participants
@jplatte @turt2live