Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose libolm migration code in wasm bindings #78

Closed
richvdh opened this issue Dec 15, 2023 · 2 comments · Fixed by #77
Closed

Expose libolm migration code in wasm bindings #78

richvdh opened this issue Dec 15, 2023 · 2 comments · Fixed by #77
Assignees

Comments

@richvdh
Copy link
Member

richvdh commented Dec 15, 2023

The FFI bindings have a bunch of code to take libolm-pickled objects and store them in a matrix-rust-sdk CryptoStore.

To support migration in Element-Web R, I think we need to push as much of this as we can down to matrix-sdk-crypto, and then expose it in the wasm bindings.

@bnjbvr
Copy link
Member

bnjbvr commented Dec 18, 2023

Can you expand a bit? Have the libolm objects been created by the Rust SDK in the first place?

@richvdh
Copy link
Member Author

richvdh commented Dec 18, 2023

Can you expand a bit? Have the libolm objects been created by the Rust SDK in the first place?

No, they are created by the application.

I don't really have any more detail at the moment. All I know is that there is a load of code in the FFI bindings, none of which looks very specific to FFI, and which we need to replicate in the wasm bindings. My hope is that we can save a lot of copying-and-pasting by moving this code to somewhere common, like matrix-sdk-crypto.

I plan to look at it later this week.

@richvdh richvdh self-assigned this Dec 19, 2023
@richvdh richvdh changed the title Push libolm migration code down from FFI bindings to crypto crate and expose in wasm bindings Expose libolm migration code in wasm bindings Dec 29, 2023
@bnjbvr bnjbvr transferred this issue from matrix-org/matrix-rust-sdk Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants