Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove ListResetDefault #8769

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Remove ListResetDefault #8769

merged 1 commit into from
Jun 5, 2022

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 5, 2022

The mixin is used only here once. Also to reset lists, they should be globally reset with selectors instead of applying the mixin ad-hoc, in order to protect the lists from unexpected style inconsistencies.

Signed-off-by: Suguru Hirahara [email protected]

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Suguru Hirahara <[email protected]>
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 5, 2022
@luixxiul luixxiul marked this pull request as ready for review June 5, 2022 18:37
@luixxiul luixxiul requested a review from a team as a code owner June 5, 2022 18:37
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimonBrandner SimonBrandner enabled auto-merge (squash) June 5, 2022 18:38
@SimonBrandner SimonBrandner merged commit 5ca0357 into matrix-org:develop Jun 5, 2022
@luixxiul luixxiul deleted the DialogSideBar2 branch June 6, 2022 01:48
JanBurp pushed a commit to JanBurp/matrix-react-sdk that referenced this pull request Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants