From eb33af94d192f412e265f2d8842a8578a9f8b77c Mon Sep 17 00:00:00 2001 From: Travis Ralston Date: Wed, 13 Mar 2019 15:24:05 -0600 Subject: [PATCH 1/2] Fix 'forgot password' warning to represent the reality of e2ee Fixes https://github.com/vector-im/riot-web/issues/6681 --- .../structures/auth/ForgotPassword.js | 24 ++++--------------- src/i18n/strings/en_EN.json | 2 +- 2 files changed, 5 insertions(+), 21 deletions(-) diff --git a/src/components/structures/auth/ForgotPassword.js b/src/components/structures/auth/ForgotPassword.js index f0a53e5063c..3c968737663 100644 --- a/src/components/structures/auth/ForgotPassword.js +++ b/src/components/structures/auth/ForgotPassword.js @@ -124,20 +124,13 @@ module.exports = React.createClass({ description:
{ _t( - 'Resetting password will currently reset any ' + - 'end-to-end encryption keys on all devices, ' + - 'making encrypted chat history unreadable, ' + - 'unless you first export your room keys and re-import ' + - 'them afterwards. In future this will be improved.', + "Changing your password will reset any end-to-end encryption keys " + + "on all of your devices, making encrypted chat history unreadable. Set up " + + "Key Backup or export your room keys from another device before resetting your " + + "password.", ) }
, button: _t('Continue'), - extraButtons: [ - , - ], onFinished: (confirmed) => { if (confirmed) { this.submitPasswordReset( @@ -150,15 +143,6 @@ module.exports = React.createClass({ } }, - _onExportE2eKeysClicked: function() { - Modal.createTrackedDialogAsync('Export E2E Keys', 'Forgot Password', - import('../../../async-components/views/dialogs/ExportE2eKeysDialog'), - { - matrixClient: MatrixClientPeg.get(), - }, - ); - }, - onInputChanged: function(stateKey, ev) { this.setState({ [stateKey]: ev.target.value, diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index 8cc85b60368..2bda11a1dd1 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -1423,7 +1423,7 @@ "The email address linked to your account must be entered.": "The email address linked to your account must be entered.", "A new password must be entered.": "A new password must be entered.", "New passwords must match each other.": "New passwords must match each other.", - "Resetting password will currently reset any end-to-end encryption keys on all devices, making encrypted chat history unreadable, unless you first export your room keys and re-import them afterwards. In future this will be improved.": "Resetting password will currently reset any end-to-end encryption keys on all devices, making encrypted chat history unreadable, unless you first export your room keys and re-import them afterwards. In future this will be improved.", + "Changing your password will reset any end-to-end encryption keys on all of your devices, making encrypted chat history unreadable. Set up Key Backup or export your room keys from another device before resetting your password.": "Changing your password will reset any end-to-end encryption keys on all of your devices, making encrypted chat history unreadable. Set up Key Backup or export your room keys from another device before resetting your password.", "Your Matrix account": "Your Matrix account", "Your Matrix account on %(serverName)s": "Your Matrix account on %(serverName)s", "The homeserver URL %(hsUrl)s doesn't seem to be valid URL. Please enter a valid URL including the protocol prefix.": "The homeserver URL %(hsUrl)s doesn't seem to be valid URL. Please enter a valid URL including the protocol prefix.", From 3d2b0f861c558444ef25a115030232ec0289b078 Mon Sep 17 00:00:00 2001 From: Travis Ralston Date: Wed, 13 Mar 2019 15:33:14 -0600 Subject: [PATCH 2/2] Clean up unused imports For the almighty linter --- src/components/structures/auth/ForgotPassword.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/structures/auth/ForgotPassword.js b/src/components/structures/auth/ForgotPassword.js index 3c968737663..8c7bf50bcfe 100644 --- a/src/components/structures/auth/ForgotPassword.js +++ b/src/components/structures/auth/ForgotPassword.js @@ -20,7 +20,6 @@ import PropTypes from 'prop-types'; import { _t } from '../../../languageHandler'; import sdk from '../../../index'; import Modal from "../../../Modal"; -import MatrixClientPeg from "../../../MatrixClientPeg"; import SdkConfig from "../../../SdkConfig"; import PasswordReset from "../../../PasswordReset";