This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Pass more strictNullChecks by changing onFinished in ComponentType to non-optional #10387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
… non-optional I believe this helps because the gymnastics with ComponentProps makes onFinished doubly-optional, which then doesn't match the types of the props of the dialog we are passing in to Modal.createDialog. Reduces the number of strict errors by ~200 and does not introduce any new ones.
andybalaam
force-pushed
the
andybalaam/strictnullchecks-createDialog
branch
from
84e932a
to
674eff1
Compare
|
@t3chguy would appreciate your thoughts on the second commit: 674eff1 I got to this point by working backwards from the types |
|
Actually, this does not work. We still need the |
Comment on lines
108
to
+115
| public createDialog<C extends ComponentType>( | ||
| Element: C, | ||
| props?: ComponentProps<C>, | ||
| props?: WithOnFinished, | ||
| className?: string, | ||
| isPriorityModal = false, | ||
| isStaticModal = false, | ||
| options: IOptions<C> = {}, | ||
| ): IHandle<C> { | ||
| options: IOptions = {}, | ||
| ): IHandle { |
There was a problem hiding this comment.
Maybe these new changes solve element-hq/element-web#24899?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is marked as an internal change (Task), so will not be included in the changelog.