From d9f71d938409755f0e61d130425305a7684879a2 Mon Sep 17 00:00:00 2001 From: Janne Mareike Koschinski Date: Tue, 26 Apr 2022 12:26:43 +0200 Subject: [PATCH] Add comment explaining why we're using this fallback for read receipt members --- src/components/views/rooms/ReadReceiptGroup.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/components/views/rooms/ReadReceiptGroup.tsx b/src/components/views/rooms/ReadReceiptGroup.tsx index 3325defc118..a427c74e072 100644 --- a/src/components/views/rooms/ReadReceiptGroup.tsx +++ b/src/components/views/rooms/ReadReceiptGroup.tsx @@ -204,6 +204,10 @@ function ReadReceiptPerson({ userId, roomMember, ts, isTwelveHour, onAfterClick onClick={() => { dis.dispatch({ action: Action.ViewUser, + // XXX: We should be using a real member object and not assuming what the receiver wants. + // The ViewUser action leads to the RightPanelStore, and RightPanelStoreIPanelState defines the + // member property of IRightPanelCardState as `RoomMember | User`, so we’re fine for now, but we + // should definitely clean this up later member: roomMember ?? { userId } as User, push: false, });