[WIP] MX3PidAddManager: New class to handle add 3pids to HS and to bind to IS #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1365,6 +1368,27 @@ public extension MXRestClient { | |||
| @nonobjc @discardableResult func addThirdPartyIdentifier(_ sid: String, clientSecret: String, bind: Bool, completion: @escaping (_ response: MXResponse<Void>) -> Void) -> MXHTTPOperation { | |||
There was a problem hiding this comment.
We can add depreciation annotation on method like this:
@available(*, deprecated, message: "use addThirdPartyIdentifierOnly instead")
| } failure:failure]; | ||
| } | ||
|
|
||
| - (MXHTTPOperation *)doesServerSupportSeparateAddAndBind:(void (^)(bool doesServerSupportSeparateAddAndBind))success |
There was a problem hiding this comment.
Prefer use BOOL instead bool for doesServerSupportSeparateAddAndBind.
|
|
||
| #pragma mark - Bind Email | ||
|
|
||
| - (MX3PidAddSession*)startIdentityServerEmailSessionWithEmail:(NSString*)email |
There was a problem hiding this comment.
Maybe rename startIdentityServerBindEmailSessionWithEmail to add more context like startAddEmailSessionWithEmail above.
| return threePidAddSession; | ||
| } | ||
|
|
||
| - (void)tryFinaliseIdentityServerEmailSession:(MX3PidAddSession*)threePidAddSession |
There was a problem hiding this comment.
Maybe rename tryFinaliseIdentityServerBindEmailSession to add more context like tryFinaliseAddEmailSession` above.
|
|
||
| threePidAddSession.httpOperation = nil; | ||
|
|
||
| NSLog(@"[MX3PidAddManager] tryFinaliseIdentityServer3PidSessionWithNewHomeserver: DONE: threePid: %@", threePidAddSession); |
There was a problem hiding this comment.
startIdentityServer3PidSession instead of tryFinaliseIdentityServer3PidSessionWithNewHomeserver.
SBiOSoftWhare
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This manager handles all HS flags. It adds, binds, unbinds 3pids, accordingly.
Apps should use it instead of MXK3Pid.
Note: All possible IS configurations are already managed by the
MXIdentityServicethis manager uses.Part of element-hq/element-ios#2713:
m.separate_add_and_bind)POST /_matrix/client/r0/account/3pid/bind,POST /_matrix/client/r0/account/3pid/unbind, andPOST /_matrix/client/r0/account/3pid/add/unstableprefix for APIs