Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose rest client method for generating login tokens through MSC3882 #1601

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

stefanceriu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 13.66% // Head: 13.66% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0d588b0) compared to base (29222ee).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1601      +/-   ##
===========================================
- Coverage    13.66%   13.66%   -0.01%     
===========================================
  Files          543      543              
  Lines        86908    86944      +36     
  Branches     36904    36924      +20     
===========================================
+ Hits         11878    11880       +2     
- Misses       74586    74620      +34     
  Partials       444      444              
Impacted Files Coverage Δ
MatrixSDK/Contrib/Swift/MXRestClient.swift 1.56% <0.00%> (-0.02%) ⬇️
MatrixSDK/JSONModels/MXJSONModels.m 6.65% <0.00%> (-0.06%) ⬇️
MatrixSDK/MXRestClient.m 2.46% <0.00%> (-0.02%) ⬇️
MatrixSDKTests/MXHTTPAdditionalHeadersUnitTests.m 76.59% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a note.

MatrixSDK/MXRestClient.m Outdated Show resolved Hide resolved
@stefanceriu
Copy link
Member Author

This should be correct now although our current test synapse instance doesn't support it

@stefanceriu stefanceriu merged commit 66aefba into develop Oct 10, 2022
@stefanceriu stefanceriu deleted the stefan/loginTokenGeneration branch October 10, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants