Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for MSC3881 #1590

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Conversation

gileluard
Copy link
Contributor

@gileluard gileluard commented Oct 3, 2022

needed for #6787

@gileluard gileluard marked this pull request as draft October 3, 2022 11:43
@gileluard gileluard requested review from a team and pixlwave and removed request for a team October 3, 2022 11:44
@gileluard gileluard marked this pull request as ready for review October 3, 2022 11:59
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 13.50% // Head: 13.50% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (570a752) compared to base (c1571d1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1590      +/-   ##
===========================================
- Coverage    13.50%   13.50%   -0.01%     
===========================================
  Files          541      541              
  Lines        86542    86579      +37     
  Branches     36768    36779      +11     
===========================================
+ Hits         11689    11693       +4     
- Misses       74411    74444      +33     
  Partials       442      442              
Impacted Files Coverage Δ
...rixSDK/Contrib/Swift/JSONModels/MXJSONModels.swift 0.00% <0.00%> (ø)
MatrixSDK/Contrib/Swift/MXRestClient.swift 1.58% <0.00%> (-0.02%) ⬇️
MatrixSDK/JSONModels/MXMatrixVersions.m 0.00% <0.00%> (ø)
MatrixSDK/JSONModels/Push/MXPusher.m 0.00% <0.00%> (ø)
MatrixSDK/MXRestClient.m 2.47% <0.00%> (-0.01%) ⬇️
MatrixSDKTests/MXHTTPAdditionalHeadersUnitTests.m 85.10% <0.00%> (+8.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

MatrixSDK/MXRestClient.m Show resolved Hide resolved
MatrixSDK/JSONModels/MXMatrixVersions.m Outdated Show resolved Hide resolved
MatrixSDK/Contrib/Swift/JSONModels/MXJSONModels.swift Outdated Show resolved Hide resolved
- Update after review
@gileluard gileluard merged commit 7934ebc into develop Oct 4, 2022
@gileluard gileluard deleted the gil/6787-Add_support_for_MSC3881 branch October 4, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants