This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
vertical padding is borked on new attachment UI after going into file selector and out again #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As an FYI, the only issue here is that the detection of the external keyboard doesn't work anymore. This happens typically in a view controller after having presented another view controller. There are some discussions here. I don't like this fix but it's the only reliable one I found. |
gileluard
changed the title
manuroe
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
I created a dedicated issue for external keyboard: element-hq/element-ios#4180
- fixed default padding between last message and composer - increased animation speed
- made animation speed configurable
ismailgulek
reviewed
Apr 8, 2021
Co-authored-by: ismailgulek <[email protected]>
ismailgulek
approved these changes
Apr 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix element-hq/element-ios#4156