Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix startup failure #321

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Fix startup failure #321

merged 3 commits into from
Nov 16, 2022

Conversation

Half-Shot
Copy link
Collaborator

This fixes a crash on startup due to a change in how matrix-appservice-bridge works, that evaded our testing entirely.

@Half-Shot Half-Shot requested a review from a team as a code owner November 10, 2022 09:56
jaller94
jaller94 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only approving this because I don't expect this to break.
But it looks like a Work In Progress PR with the use of console.log and commented out log. line.

src/Program.ts Outdated Show resolved Hide resolved
src/Metrics.ts Outdated Show resolved Hide resolved
@Half-Shot Half-Shot merged commit 89c88b0 into develop Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @jaller94