Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MSC3787 #309

Closed
DMRobertson opened this issue May 19, 2022 · 0 comments · Fixed by #310
Closed

Support MSC3787 #309

DMRobertson opened this issue May 19, 2022 · 0 comments · Fixed by #310
Assignees

Comments

@DMRobertson
Copy link
Contributor

matrix-org/complement#367 for MSC3787 has landed on my plate. I also have no idea what I'm doing, but maybe I can work it out.

As Kegan details in matrix-org/complement#367 (review), someone needs to teach gomatrixserverlib about the new room version. But there isn't actually anyone pushing for this, so you'll have to make do with me.

The status today:

  • Room version 7 allowed a join_rule of knock. Any room with this join rule could be knocked upon.
  • Room version 9 allowed a join_rule of restricted. Any room with this join rule could be joined based on membership of a space.

This new room version introduces a new join_rule for a room called knock_restricted. Rooms with this join_rule:

  • allow knocking, as in room version 7, and
  • allow joining based on membership of a space, as in room version 9.

Implementation.

We need a new entry in the roomVersionMeta map.

The rest TBD.

@DMRobertson DMRobertson self-assigned this May 19, 2022
@DMRobertson DMRobertson linked a pull request May 24, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant