Add lazy-loading /sync tests for faster room joins
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 10, 2022 17:26
Test that lazy-loading `/sync`s do not block when receiving events from remote senders. Also test that lazy-loading `/sync`s return the appropriate memberships for event senders.
|
The three new tests have a lot of duplicate code. Suggestions for tidying them up are welcome. |
This was referenced Aug 10, 2022
erikjohnston
approved these changes
Aug 17, 2022
| if err == nil { | ||
| t.Errorf("gappy /sync returned the first event unexpectedly") | ||
| } | ||
|
|
There was a problem hiding this comment.
I wonder if we should also assert that the limited flag is set? I don't think it matters much for this test, but in general I think it might avoid potential pitfalls to explicitly assert that.
There was a problem hiding this comment.
I've added a check for the limited flag.
|
Do not merge this yet - the objections from #440 need to be resolved. |
squahtx
requested review from
erikjohnston and
kegsay
and removed request for
kegsay and
erikjohnston
erikjohnston
approved these changes
Aug 23, 2022
squahtx
deleted the
squah/faster_room_joins_unblock_lazy_loading_sync_2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that lazy-loading
/syncs do not block when receiving events fromremote senders. Also test that lazy-loading
/syncs return theappropriate memberships for event senders.
Contains some changes from #440 and #441.