Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dedicated client-specific tests #132

Open
kegsay opened this issue Sep 13, 2024 · 0 comments
Open

Allow dedicated client-specific tests #132

kegsay opened this issue Sep 13, 2024 · 0 comments
Assignees

Comments

@kegsay
Copy link
Member

kegsay commented Sep 13, 2024

The tooling in complement-crypto is useful enough that it's often easier to write end-to-end tests in it than client-specific integration tests (e.g rust SDK). Unfortunately, the current structure/design has worked hard to make the tests agnostic to the underlying client implementation, but there is value in allowing tests to test client-specific things. We effectively already do this in places (e.g the notification tests which are very rust SDK focused), but we just kind of awkwardly add functions to the generic client interface.

Ideally, we should just let tests type-cast to a concrete impl. Considerations though:

  • the impl may be behind an RPC barrier, so really we want to cast to a more specific interface than a real concrete impl,
  • the specific impl/interface may not exist if it hasn't been built with the right -tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant