Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when the file save dialog is cancelled #54

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Fix crash when the file save dialog is cancelled #54

merged 1 commit into from
Feb 18, 2020

Commits on Feb 18, 2020

  1. Fix crash when the file save dialog is cancelled 

    The filename is an empty string when the file save dialog is cancelled, which results in an attempt to open a non-existent file in `ViewerWindow`'s `save()`, `EditorWindow`'s `export()` and `save()`. Since the error isn't caught viscm terminates. This fix checks if the returned string is empty and if it is, no file I/O operation is performed.
    @robertguetzkow
    robertguetzkow committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    5e28e9a View commit details
    Browse the repository at this point in the history