Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up from new custom action parameters #363

Closed
tsteur opened this issue Nov 15, 2020 · 3 comments · Fixed by #369
Closed

Follow up from new custom action parameters #363

tsteur opened this issue Nov 15, 2020 · 3 comments · Fixed by #369

Comments

@tsteur
Copy link
Member

tsteur commented Nov 15, 2020

Follow up from #355 and #354

We just realised that this new ca=1 parameter should not be sent in goals and ecommerce tracking requests but only for events and optionally content tracking requests (if this is implemented).

If I understand the PR right this is already the case but wanted to double check to make sure &ca=1 is not sent for any goal tracking or ecommerce tracking request.

Cheers

@brototyp
Copy link
Member

brototyp commented Dec 13, 2020

Hey @tsteur,

thanks for bringing this one in. I wanted to check back, to make sure we get it correct this time.

I am not sure if I clearly understand when the parameter should be sent and when it shouldn't. I am esp. curious about events we haven't implemented yet, e.g. media analytics and such.

As the documentation isn't really explicit about this: Is there a definition on when these events should be sent and when not? In this implementation everything is an event. A page view, an e-commerce tracking event, an action ...

Thanks a lot!

@tsteur
Copy link
Member Author

tsteur commented Dec 13, 2020

Hi @brototyp in this case you basically only need to append it for an event tracking request. Not for any other kind of tracking requests.

@brototyp
Copy link
Member

brototyp commented Jan 3, 2021

Thanks @tsteur
This is released in v7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants