Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match browser implementations (e.g. ) #12

Open
mathiasbynens opened this issue Nov 5, 2012 · 6 comments
Open

Match browser implementations (e.g. ) #12

mathiasbynens opened this issue Nov 5, 2012 · 6 comments

Comments

@mathiasbynens
Copy link
Owner

@annevk reported this one.

[13:19] <annevk> matjas: you around? saw that 1 turns into some Punycode string per http://mothereff.in/punycode but no browser does that, not even Opera  
[13:20] <annevk> matjas: so if that's IDNA2008... well... 

http://mothereff.in/punycode#%EF%BC%91.com

AFAICT, that’s just the Punycode algorithm doing its thing. I guess browsers normalize the input first?

@annevk
Copy link

annevk commented Nov 5, 2012

So I think you guys are good as far as the Punycode algorithm is concerned. But there's a bunch of pre-processing that's unclear and differs slightly between browsers. Trying to sort it out.

@mathiasbynens
Copy link
Owner Author

@mathiasbynens
Copy link
Owner Author

@mathiasbynens
Copy link
Owner Author

@annevk
Copy link

annevk commented Jan 6, 2017

I guess maybe this isn't as important for this library if other libraries are writing the ToASCII logic on top... Depends a bit on what you're aiming for and what users expect I suppose.

@mathiasbynens
Copy link
Owner Author

punycode.toASCII was altering ASCII-safe input strings: #59 This has been fixed in v2.1.0. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants