Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL cell loses focus when clicking on its contained hyperlink #2988

Closed
seancolsen opened this issue Jul 3, 2023 · 0 comments · Fixed by #3012
Closed

URL cell loses focus when clicking on its contained hyperlink #2988

seancolsen opened this issue Jul 3, 2023 · 0 comments · Fixed by #3012
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

Steps to reproduce

  1. Prerequisites:

    1. On the table page click on a cell to focus it.
    2. When the cell is focused, you can use the Up and Down arrow keys to move the active cell. This is good.
    3. Click on the "Filter" button above the table to open the filtering dropdown. Click it again to close it. Now that button is focused instead of a cell, and you won't be able to use the arrow keys to move the active cell. This is okay, but important to understand.
  2. Set up a column with a URL type.

  3. Into a cell in that column, enter a relatively short URL like http://a.b

  4. Click on different cell to make your URL cell inactive.

  5. On your inactive URL cell, click the link text.

  6. Observe that the cell is selected and active (has a thick border). Good!

  7. Expect the cell to also be focused, but instead observe that it is not focused (because the link inside the cell is focused instead). Bad.

  8. Click on some empty space in the cell but outside the link. Now observe the cell to be focused. Good.

@seancolsen seancolsen added ready Ready for implementation type: bug work: frontend Related to frontend code in the mathesar_ui directory good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Jul 3, 2023
@seancolsen seancolsen added this to the Backlog milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant