Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell Context menu event should maintain the cell selection when triggered within the selection #1771

Open
Tracked by #3150
seancolsen opened this issue Oct 8, 2022 · 7 comments
Labels
help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Oct 8, 2022

Steps to reproduce

  1. Select a block of cells.
  2. Trigger the context menu on a cell outside the selected block.
  3. Observe the cell selection to change, selecting only the cell on which the context menu was triggered. (good)
  4. Select a block of cells again.
  5. Trigger the context menu on a cell inside the selected block.
  6. Expect the cell selection to remain unchanged when the context menu opens.
  7. Observe the cell selection to change, selecting only the cell on which the context menu was triggered. (bad)

When the context menu opens on a block of selected cells, it should contain only one entry — an entry to "Delete Records" (which should delete all selected records). We already have this "delete multiple records" functionality built into the table inspector under the "Record" tab.

@monstajoe2002

This comment was marked as resolved.

@seancolsen

This comment was marked as resolved.

@monstajoe2002

This comment was marked as resolved.

@seancolsen

This comment was marked as resolved.

@rajatvijay
Copy link
Contributor

@seancolsen I had a question on this issue:

Since we do not have any action in the context menu as of now that works on multiple cells together, what is that menu supposed to show?

@seancolsen seancolsen added status: draft and removed ready Ready for implementation help wanted Community contributors can implement this labels Mar 15, 2023
@seancolsen
Copy link
Contributor Author

@rajatvijay that's a really good point. Thanks for raising this. After giving it some more thought, I think we should draft this issue until the point when we do have context menu actions that can operate on multiple cells.

@monstajoe2002 you can find another issue to work on if you like

@seancolsen seancolsen added ready Ready for implementation and removed status: draft labels Nov 17, 2023
@seancolsen seancolsen added the help wanted Community contributors can implement this label Nov 17, 2023
@seancolsen
Copy link
Contributor Author

Now that we have the ability to delete multiple records at once, I'm marking this ticket as ready, and I've updated the description to specify the content of the context menu when opened on multiple cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

3 participants