Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint-plugin-import and enable consistent-type-specifier-style #1729

Closed
seancolsen opened this issue Sep 23, 2022 · 4 comments
Closed
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: maintenance Refactoring and technical debt payoff work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Sep 23, 2022

  • ESLint recently added a new rule consistent-type-specifier-style. Because this rule is auto-fixable, it will allow us to keep all our type imports organized well, avoiding problems when auto-adding imports.

  • It appears that this feature is slated for inclusion in their next release, v2.27.0. When that release is available, we should upgrade to it so that we can enable this rule.

  • Then we should configure .eslintrc.cjs as follows:

    {
      rules: {
        'import/consistent-type-specifier-style': ['error', 'prefer-inline'],
      }
    }
@seancolsen seancolsen added ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory restricted: maintainers Only maintainers can resolve this issue labels Sep 23, 2022
@snewcomer
Copy link

Unsure if this is helpful, but there will be a trio of settings to configure!

import-js/eslint-plugin-import#2475 (comment)

@seancolsen
Copy link
Contributor Author

Wow, thanks @snewcomer! Looking forward to this!

@github-actions
Copy link

This issue has not been updated in 90 days and is being marked as stale.

@github-actions github-actions bot added the stale label May 29, 2023
@rajatvijay rajatvijay removed the stale label May 31, 2023
@seancolsen seancolsen added type: maintenance Refactoring and technical debt payoff and removed type: enhancement New feature or request labels May 9, 2024
@seancolsen
Copy link
Contributor Author

I'm closing this because I think it's irrelevant now that we're auto-sorting our entire import sections via #3552.

@seancolsen seancolsen closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: maintenance Refactoring and technical debt payoff work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

3 participants