Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock funepos and funeneg #1442

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Lock funepos and funeneg #1442

merged 1 commit into from
Dec 20, 2024

Conversation

Tragicus
Copy link
Collaborator

@Tragicus Tragicus commented Dec 20, 2024 •
edited
Loading

Motivation for this change

Locks funepos and funeneg, as they trigger very long unification problems (as observed here). This saves 6% of the compilation time.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@proux01
Copy link
Collaborator

proux01 commented Dec 20, 2024

Let's merge once CI is green

@affeldt-aist affeldt-aist merged commit dafc6cf into math-comp:master Dec 20, 2024
31 of 32 checks passed
@Tragicus Tragicus deleted the lock_funepos branch December 20, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proux01 proux01 proux01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tragicus @proux01 @affeldt-aist