Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few improvements #2

Conversation

kelset
Copy link
Collaborator

@kelset kelset commented Feb 14, 2023

Hey folks, opening a PR against the branch to help push this through the finish line. Happy to hop on a call and walk you through the main changes; here's a quick overview:

  • the new folder, rn-tester-e2e needs to be excluded from the monorepo - its dependencies need to be handled separately
  • documentation: I've updated the main README to be a bit more verbose, I'm still finishing work on that
  • (still to do) we need to try and move to a situation where we use the references as described here

@github-actions
Copy link

github-actions bot commented Feb 14, 2023

Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

🚫

❗ Base Branch - The base branch for this PR is something other than main or a -stable branch. Are you sure you want to target something other than the main branch?

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 6cfd308

@kelset kelset marked this pull request as ready for review February 21, 2023 16:12
This reverts commit af1dbb8.
@mateuszm22 mateuszm22 merged commit dd2307f into mateuszm22:feature/rn-tester-e2e Feb 22, 2023
@kelset kelset deleted the kelset/rn-tester-e2e-improvements branch February 23, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants