Added validation to ensure consumer does not subscribe to same topic …

…twice
mateusjunges · Oct 20, 2021 · f1ab25c · f1ab25c
1 parent acb755f
commit f1ab25c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/src/Consumers/ConsumerBuilder.php b/src/Consumers/ConsumerBuilder.php
@@ -31,19 +31,22 @@ class ConsumerBuilder
      * @param array $topics
      * @param string|null $groupId
      */
-    private function __construct(string $brokers, array $topics, string $groupId = null)
+    private function __construct(string $brokers, array $topics = [], string $groupId = null)
     {
-        foreach ($topics as $topic) {
-            $this->validateTopic($topic);
+        if (count($topics) > 0) {
+            foreach ($topics as $topic) {
+                $this->validateTopic($topic);
+            }
         }
 
         $this->brokers = $brokers;
         $this->groupId = $groupId;
-        $this->topics = $topics;
+        $this->topics = array_unique($topics);
 
         $this->commit = 1;
         $this->handler = function () {
         };
+
         $this->maxMessages = -1;
         $this->maxCommitRetries = 6;
         $this->middlewares = [];
@@ -84,7 +87,9 @@ public function subscribe(...$topics): self
         foreach ($topics as $topic) {
             $this->validateTopic($topic);
 
-            $this->topics[] = $topic;
+            if (! collect($this->topics)->contains($topic)) {
+                $this->topics[] = $topic;
+            }
         }
 
         return $this;

diff --git a/tests/Consumers/ConsumerBuilderTest.php b/tests/Consumers/ConsumerBuilderTest.php
@@ -32,6 +32,17 @@ public function testItCanSubscribeToATopic()
         $this->assertEquals(['foo'], $topics);
     }
 
+    public function testItDoesNotSubscribeToATopicTwice()
+    {
+        $consumer = ConsumerBuilder::create('broker');
+
+        $consumer->subscribe('foo', 'foo');
+
+        $topics = $this->getPropertyWithReflection('topics', $consumer);
+
+        $this->assertEquals(['foo'], $topics);
+    }
+
     public function testICanChangeDeserializersOnTheFly()
     {
         $consumer = ConsumerBuilder::create('broker');