Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_band_structure_from_vasp_multiple_branches #4060

Open
Nokimann opened this issue Sep 11, 2024 · 1 comment · May be fixed by #4061
Open

get_band_structure_from_vasp_multiple_branches #4060

Nokimann opened this issue Sep 11, 2024 · 1 comment · May be fixed by #4061
Labels

Comments

@Nokimann
Copy link

Python version

PYthon 3.12.5

Pymatgen version

2024.8.9

Operating system version

CentOS 7.6

Current behavior

in pymatgen/io/vasp/output.py

get_band_structure_from_vasp_multiple_branches

if os.path.isfile(f"{dir_name}/branch_0"):

Expected Behavior

get_band_structure_from_vasp_multiple_branches

the line if os.path.isfile(f"{dir_name}/branch_0"):

check the filename for the dirname

So, it return None always.

I don't know why the newest version changed.

Minimal example

from pymatgen.io.vasp.outputs import get_band_structure_from_vasp_multiple_branches

bs = get_band_structure_from_vasp_multiple_branches('./bs')

print(bs == None)

Relevant files to reproduce this bug

No response

@Nokimann Nokimann added the bug label Sep 11, 2024
@DanielYang59
Copy link
Contributor

Hi @Nokimann thanks for reporting this. I could confirm this issue introduced by #3690, would fix ASAP.

Meanwhile is it possible to share your files such that we could enhance unit test (this function is not covered by unit test)? Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants