Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out S3 Object reference keys from search keys #206

Closed
shyamd opened this issue Jun 23, 2020 · 0 comments · Fixed by #265
Closed

Separate out S3 Object reference keys from search keys #206

shyamd opened this issue Jun 23, 2020 · 0 comments · Fixed by #265

Comments

@shyamd
Copy link
Contributor

shyamd commented Jun 23, 2020

It's a little ambiguous on how to set up the S3 store to have some subset of search data in the index. This is partly because the keys for creating the S3 Object and the index keys are the same. We should make an init attribute in the S3Store: metadata or something that the user supplies for fields they want to be able to search on. The S3Store should use the keys field to determine uniqueness when it looks for a doc in the index DB to update. This will make it so that the naming of the blob in S3 can just be something like an OID.

@jmmshn @munrojm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant