-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insufficient information stored to recover parent-child relationship between jobs from their JobStore
output docs?
#374
Comments
Hi @mkhorton, this is something I've spoken to @gpetretto and @davidwaroquiers about. I believe the only other information you need to resolve the job dependencies are the The simplest way to enable this would be:
You should then be able to construct the entire flow (including nested flows) and the dependencies between jobs. The only information that will be missing is the names of the Flows (the names of the jobs are fine). The reason is that we don't store flows in the database directly. |
Thanks for the reply @utf, good to know I wasn't missing anything obvious. I'll see if I can make a PR to add this, unless @gpetretto or @davidwaroquiers are already working on it? If it'd be welcome, I'd quite like to add a |
A PR would be very welcome. And yes, agreed that we should have a document model for the job store document. |
It would indeed be very useful to be able to "reconstruct" the Flow(s) after they have run (or while they are running) in order to visualize them. We've indeed already discussed about this but haven't started working on this. This issue also falls within a set of other features that would be nice to have and are somewhat interconnected. I would maybe like to raise the idea to have a meeting with the most active developers/contributors in order to list out and somehow plan for the short/mid-term developments. @utf What do you think ? |
@mkhorton did you end up starting work on this? I offered to make some contributions to jobflow and would love to tackle this, and am planning to start working on it now. Happy to hold off/coordinate though if you have any concerns or WIP. |
By all means Max, go ahead! I do not have a WIP. Let me know if you have any problems however (perhaps open a PR early so anyone interested can comment?) |
Sounds good Matt! Early PR is a good idea for sure. |
Please advise if I've mis-interpreted the code/docs.
Assume:
Job
outputs viaJobStore
.jobflow
directly.For a given document in the
JobStore
, I seeuuid
, I also seehosts
(which can be used to see that a givenJob
belongs to the sameFlow
), however, that I can see, there is no way to see the dependency relationship between two or moreJob
output documents, is this correct?If correct, is this intended usage? What would be a minimal way to retain this information, without adding a dependency on a specific workflow manager?
The text was updated successfully, but these errors were encountered: