Skip to content
This repository has been archived by the owner on Oct 14, 2021. It is now read-only.

[objc] Category line movement generates non-sensical API diff #25

Open
jverkoey opened this issue Sep 20, 2018 · 0 comments
Open

[objc] Category line movement generates non-sensical API diff #25

jverkoey opened this issue Sep 20, 2018 · 0 comments
Labels

Comments

@jverkoey
Copy link
Contributor

Strange changes when category implementations are shifted down in a file.

Repro case

Before

@interface MDCFlexibleHeaderView: UIView
@property(nonatomic, strong) UIView *someView;
@end

@interface MDCFlexibleHeaderView ()

#pragma mark Accessing the header's views

/** Deprecated. Please register views directly to the flexible header. */
@property(nonatomic, strong, nonnull) UIView *contentView;

@end

After

@interface MDCFlexibleHeaderView: UIView
@property(nonatomic, strong) UIView *someView;
@property(nonatomic, strong) UIView *anotherView;
@end

@interface MDCFlexibleHeaderView ()

#pragma mark Accessing the header's views

/** Deprecated. Please register views directly to the flexible header. */
@property(nonatomic, strong, nonnull) UIView *contentView;

@end

Partial generated output

None of the following is expected to be generated:

#### MDCFlexibleHeaderView()

 *new* category: `MDCFlexibleHeaderView()`

 *removed* category: `MDCFlexibleHeaderView()`

 *modified* property: `contentView` in `MDCFlexibleHeaderView()`

 | Type of change: | parent.usr |
|---|---|
| From: | `c:objc(ext)[email protected]@14009` |
| To: | `c:objc(ext)[email protected]@14344` |
@jverkoey jverkoey added the Bug label Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant