From d1fb068d620130a9157a69930e8af14dc6978775 Mon Sep 17 00:00:00 2001
From: Elizabeth Mitchell <lizmitchell@google.com>
Date: Wed, 3 Aug 2022 13:33:39 -0700
Subject: [PATCH] chore(field): update animations

PiperOrigin-RevId: 465135334
---
 field/lib/_label.scss          | 95 ++++++++--------------------------
 field/lib/_outlined-field.scss |  1 -
 field/lib/field.ts             |  1 +
 3 files changed, 24 insertions(+), 73 deletions(-)

diff --git a/field/lib/_label.scss b/field/lib/_label.scss
index ecd272890d..d19781a464 100644
--- a/field/lib/_label.scss
+++ b/field/lib/_label.scss
@@ -8,91 +8,42 @@
 
 @mixin static-styles() {
   .md3-field__label {
-    @include label;
+    overflow: hidden;
+    max-width: 100%;
+    // The resting label at 100% height can block pointer events to the content
+    // if it's very long and spans the full width of the field. Additionally,
+    // selecting the label's text doesn't present a good UX, since the user
+    // selection should be re-focused to another element (such as the input)
+    // upon focusing. Finally, since the actual label elements are swapped, it
+    // is not easy to maintain the user's label text selection.
+    pointer-events: none;
+    // TODO: Check with design, should there be any transition from resting to
+    // floating when there is a mismatch between ellipsis, such as opacity
+    // transition?
+    text-overflow: ellipsis;
+    white-space: nowrap;
+    z-index: 1;
   }
 
   .md3-field__label--resting {
-    @include resting;
+    position: absolute;
+    top: 50%;
+    transform: translateY(-50%);
+    /*rtl:ignore*/
+    transform-origin: top left;
   }
 
   .md3-field__label--floating {
-    @include floating;
+    /*! Used in field.ts @queryAsync. go/css-conformance#unstyled-classes */
   }
 
   .md3-field__label--hidden {
-    @include hidden;
+    opacity: 0;
   }
 
   .md3-field--no-label {
     .md3-field__label {
-      @include no-label;
+      display: none;
     }
   }
 }
-
-// TODO: Shake animation
-
-@mixin label() {
-  overflow: hidden;
-  max-width: 100%;
-  // The resting label at 100% height can block pointer events to the content
-  // if it's very long and spans the full width of the field. Additionally,
-  // selecting the label's text doesn't present a good UX, since the user
-  // selection should be re-focused to another element (such as the input)
-  // upon focusing. Finally, since the actual label elements are swapped, it
-  // is not easy to maintain the user's label text selection.
-  pointer-events: none;
-  // TODO: Check with design, should there be any transition from resting to
-  // floating when there is a mismatch between ellipsis, such as opacity
-  // transition?
-  text-overflow: ellipsis;
-  white-space: nowrap;
-  z-index: 1;
-}
-
-@mixin no-label() {
-  display: none;
-}
-
-@mixin resting {
-  position: absolute;
-  top: 50%;
-  transform: translateY(-50%);
-  // @include gss.annotate($noflip: true);
-  transform-origin: top left;
-  // will-change and z-index place the label on a separate composite layer
-  // and in front of other elements to avoid re-painting them as it animates.
-  will-change: transform, opacity; // TODO: Re-evaluate this after changing animations
-
-  // @include rtl.rtl {
-  //   @include gss.annotate($noflip: true);
-  //   transform-origin: top right;
-  // }
-
-  // This before element is a hack to force the text within the label to be
-  // centered. We cannot use flexbox to center the label because we want to
-  // use text-overflow on the label's content. Flexbox creates pseudo child
-  // elements when dealing with overflow that cannot be directly styled, which
-  // means we would need to wrap the label's text in a separate child element
-  // in order to properly set the text-overflow property.
-  // &::before {
-  //   content: '';
-  //   display: inline-block;
-  //   height: 100%;
-  //   vertical-align: middle;
-  // }
-}
-
-// @mixin resting() {
-//   height: 100%;
-// }
-
-@mixin floating() {
-  // Opacity changes with hidden class. Add will-chance to align with resting
-  // label optimizations for composite layer rendering.
-  will-change: opacity;
-}
-
-@mixin hidden() {
-  opacity: 0;
-}
diff --git a/field/lib/_outlined-field.scss b/field/lib/_outlined-field.scss
index b0e242c766..2f7883ea21 100644
--- a/field/lib/_outlined-field.scss
+++ b/field/lib/_outlined-field.scss
@@ -73,7 +73,6 @@ $_animation-duration: 150ms;
   pointer-events: none;
   height: 100%;
   position: absolute;
-  transition: animation.standard(border-color, $_animation-duration);
   width: 100%;
 }
 
diff --git a/field/lib/field.ts b/field/lib/field.ts
index e3e4954fdb..30fe67ed70 100644
--- a/field/lib/field.ts
+++ b/field/lib/field.ts
@@ -222,6 +222,7 @@ export class Field extends LitElement {
     //
     // Re-calculating the animation each time will prevent any visual glitches
     // from appearing.
+    // TODO(b/241113345): use animation tokens
     const animation =
         labelEl.animate(keyframes, {duration: 150, easing: Easing.STANDARD});