From f54fe92a4c00e7cdd1c55748d75fd088eb8a3a71 Mon Sep 17 00:00:00 2001 From: Andrey Prigogin Date: Mon, 5 Mar 2018 15:29:31 -0800 Subject: [PATCH 1/3] fix(button): icon in rtl should have margin right flipped. --- packages/mdc-button/_mixins.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/mdc-button/_mixins.scss b/packages/mdc-button/_mixins.scss index f8de32db86c..0c418efe0a5 100644 --- a/packages/mdc-button/_mixins.scss +++ b/packages/mdc-button/_mixins.scss @@ -16,6 +16,7 @@ @import "@material/elevation/mixins"; @import "@material/ripple/mixins"; +@import "@material/rtl/mixins"; @import "@material/theme/functions"; @import "@material/theme/mixins"; @import "@material/typography/mixins"; @@ -127,6 +128,8 @@ } @mixin mdc-button__icon_ { + @include mdc-rtl-reflexive-box(margin, right, 8px); + display: inline-block; width: 18px; height: 18px; From fe063bcc97c40347e68a7270851bceb7bc9d3023 Mon Sep 17 00:00:00 2001 From: Andrey Prigogin Date: Mon, 5 Mar 2018 16:20:23 -0800 Subject: [PATCH 2/3] fix(button): unscrewing myself. --- packages/mdc-button/_mixins.scss | 1 - packages/mdc-button/package.json | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/mdc-button/_mixins.scss b/packages/mdc-button/_mixins.scss index 0c418efe0a5..b51a3967c25 100644 --- a/packages/mdc-button/_mixins.scss +++ b/packages/mdc-button/_mixins.scss @@ -133,7 +133,6 @@ display: inline-block; width: 18px; height: 18px; - margin-right: 8px; font-size: 18px; line-height: inherit; vertical-align: top; diff --git a/packages/mdc-button/package.json b/packages/mdc-button/package.json index 6dd4dda4877..0ad21bd933d 100644 --- a/packages/mdc-button/package.json +++ b/packages/mdc-button/package.json @@ -15,6 +15,7 @@ "dependencies": { "@material/elevation": "^0.28.0", "@material/ripple": "^0.32.0", + "@material/rtl": "^0.32.0", "@material/theme": "^0.30.0", "@material/typography": "^0.28.0" } From 111e6ec9c1c9bffd6b1b6aa8eb4aeacb00ee89ca Mon Sep 17 00:00:00 2001 From: Andrey Prigogin Date: Mon, 5 Mar 2018 17:01:15 -0800 Subject: [PATCH 3/3] fix(button): wrong version rtl. --- packages/mdc-button/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/mdc-button/package.json b/packages/mdc-button/package.json index 0ad21bd933d..e181df377a0 100644 --- a/packages/mdc-button/package.json +++ b/packages/mdc-button/package.json @@ -15,7 +15,7 @@ "dependencies": { "@material/elevation": "^0.28.0", "@material/ripple": "^0.32.0", - "@material/rtl": "^0.32.0", + "@material/rtl": "^0.30.0", "@material/theme": "^0.30.0", "@material/typography": "^0.28.0" }