Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components layout incorrectly in hero section of new demo site (IE11) #633

Closed
amsheehan opened this issue May 11, 2017 · 2 comments
Closed

Comments

@amsheehan
Copy link
Contributor

amsheehan commented May 11, 2017

What MDC-Web Version are you using?

0.10.0

What browser(s) is this bug affecting?

IE11

What OS are you using?

Windows 8.1 on VirtualBox VM

What are the steps to reproduce the bug?

  1. Open demo site in IE11
  2. Navigate to any component

What is the expected behavior?

Component in hero section should be centered both horizontally and vertically.

What is the actual behavior?

The component is stuck at the top of the element

Any other information you believe would be useful?

There is a known issue: https://connect.microsoft.com/IE/feedback/details/802625/min-height-and-flexbox-flex-direction-column-dont-work-together-in-ie-10-11-preview

The fix is to set a height rule on the hero element:

.hero {
  ...
  height: 360px;
  ...
}
@traviskaufman
Copy link
Contributor

Marking as "help wanted". Fix is detailed above. That code should go into demos/demos.css.

@Aedalus
Copy link
Contributor

Aedalus commented May 11, 2017

I'm hoping to start contributing to the project, and attempted to clone/fix/make a PR here:

#636

If there are any issues with it, please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants