-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate making Bottom Navigation Component #59
Comments
https://docs.google.com/document/d/1N2f0z-HI1xpiYbiYQF-PrkvELJ3vv2Q-VrmAMzIapBU/edit?usp=sharing I need this component, so I could start its development. What do you think? |
I wrote a first functional implementation: There is still dealing with snackbars, dialogs and ripples. Please, give me some feedback so I can go forward with more documentation and tests or if on the contrary, I must change something in the current implementation. Any advice or suggestion is welcome. |
Hi @AriasBros I'm keen to test this out for you, as I've got a little project that this would be perfect for. I'm having trouble getting this running though. If you're able to talk me through getting it running I can test it out for you. (Warning I'm a bit of a newbie with web components, but very willing to learn!) |
White smoke here? |
For an item pretty essential to every app (navigation component) this issue has been open for a very long time. Is there a progress update on this? What is Google doing internally? Just not using bottom app bar in websites? I think Google often goes native apps on mobile so maybe that is why this component does not get any love on the web? |
I came across the following codepen whilst trying to track progress: https://codepen.io/eskimojo14/pen/PEVjBJ Don't know how well it follows the material design guidelines and cannot find anything else about it or the author. |
@richturner that actually seems to be a pretty good partial fix. If you look at the documentation for the bottom navigation bar it fits - mostly - the description and guidelines set by Material Design. Will have to try and implement it until they release a patch for this. |
Hey @richturner, I've also come across the same codepen while searching on Google and I thought the one who made it would have already referenced it here. So the author of this codepen seems to be @EskiMojo14 and I strongly believe he should submit this component here. |
Oh hello! Edit: the main part I struggled with was getting the ripple to work correctly on the shifting bottom nav, hence why it's not enabled on the codepen. |
@EskiMojo14 The ripple seems to be working completely fine on the codepen! |
@touficbatache works fine on the fixed (white) bottom nav, ye - it's the shifting (green) one that I couldn't work out how to do it right |
@EskiMojo14 Should be the same 🤔 |
@touficbatache nah, because the icons actually move - the way unbounded icons are handled now may make it better, not sure |
@EskiMojo14 Do you mind we talk a bit on Discord? |
@touficbatache sure, meet you in the Material Components discord? |
@EskiMojo14 Okay |
Folks any love for bottom navigation anytime soon |
Would we ever have this feature? It´s extremely common in the current times. This could be an option: https://github.com/greenyouse/bottom-nav |
Spec reference: https://material.io/go/design-bottom-navigation
Useful for mobile-specific sites and layouts.
The text was updated successfully, but these errors were encountered: