Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textfield): incorrect mixin forward path #5554

Merged

Conversation

crisbeto
Copy link
Collaborator

@crisbeto crisbeto commented Feb 1, 2020

Fixes an error that was due to a @forward which is pointing to an incorrect file path. Seems to have been introduced in 1814866.

Fixes an error that was due to a `@forward` which is pointing to an incorrect file path. Seems to have been introduced in material-components@1814866.
@mmalerba
Copy link
Collaborator

mmalerba commented Feb 1, 2020

@abhiomkar I'm not sure but it looks like the kind of thing that could point to a bug in your copybara script. You may want to look into whether that's the root cause

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the fix!

@abhiomkar
Copy link
Collaborator

@abhiomkar I'm not sure but it looks like the kind of thing that could point to a bug in your copybara script. You may want to look into whether that's the root cause

Yes, this definitely looks like incorrect Copybara transform related to @forward pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants