feat(dom): Add focus trap utility. #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joyzhong
commented
Jan 22, 2020
•
joyzhong
commented
- Adds focus trap utility class, based heavily on Wiz FocusService
- Migrates dialog and drawer components over from davidtheclark/focus-trap to new MDC focus trap
- Removes custom MDC-lint check for class private members to have trailing underscores - this is not desired per Google TS style guide.
|
All 245 screenshot tests passed for commit 4195de2 vs. |
joyzhong
force-pushed
the
cl_290989685
branch
from
4195de2
to
bcaf399
Compare
PiperOrigin-RevId: 290989685
joyzhong
force-pushed
the
cl_290989685
branch
from
bcaf399
to
6ec65b0
Compare
|
All 245 screenshot tests passed for commit bcaf399 vs. |
|
All 245 screenshot tests passed for commit 6ec65b0 vs. |
joyzhong
changed the title
|
All 236 screenshot tests passed for commit 1b85b14 vs. |
abhiomkar
reviewed
Jan 23, 2020
abhiomkar
reviewed
Jan 23, 2020
|
All 203 screenshot tests passed for commit 5302133 vs. |
|
All 203 screenshot tests passed for commit c414f53 vs. |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.