fix(select): Fix notch outline width when floating #5319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to call notch first to get width of label before it floats. Same behavior as outlined textfield
Codecov Report
@@ Coverage Diff @@
## master #5319 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 162 162
Lines 6311 6311
Branches 866 866
=======================================
Hits 6221 6221
Misses 89 89
Partials 1 1
Continue to review full report at Codecov.
|
bonniezhou
approved these changes
Dec 12, 2019
|
Next time please make sure to sync to internal first before merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to call notch first to get width of label before it floats (and is consequentially shrunk). Same behavior as outlined textfield