Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elevation): Update elevation mixins #5304

Merged
merged 3 commits into from
Dec 4, 2019
Merged

feat(elevation): Update elevation mixins #5304

merged 3 commits into from
Dec 4, 2019

Conversation

patrickrodee
Copy link
Contributor

@patrickrodee patrickrodee commented Dec 4, 2019 •
edited
Loading

Set overlay dimensions in one mixin instead of sizing and positioning in separate mixins

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit ced4980 vs. master! 💯🎉

@bwobrien bwobrien self-assigned this Dec 4, 2019
@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 3de77b4 vs. master! 💯🎉

bwobrien
bwobrien approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@bwobrien bwobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickrodee patrickrodee merged commit ba879b6 into master Dec 4, 2019
@patrickrodee patrickrodee deleted the fix/elevation/updateMixins branch December 4, 2019 20:18
This was referenced Feb 13, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@adrianschmidt adrianschmidt mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwobrien bwobrien bwobrien approved these changes

Assignees

@bwobrien bwobrien

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickrodee @mdc-web-bot @bwobrien @googlebot