Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix(select): Do not fire change event on programmatic change #5302

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

abhiomkar
Copy link
Collaborator

Reverts #5255

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #5302 into master will not change coverage.
The diff coverage is 72.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5302   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files         122      122           
  Lines        5993     5993           
  Branches      769      771    +2     
=======================================
  Hits         5911     5911           
  Misses         81       81           
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-select/foundation.ts 96.61% <72.72%> (-1.45%) ⬇️
packages/mdc-select/component.ts 98.9% <0%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f978109...4c9a57d. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 4c9a57d vs. master! 💯🎉

@abhiomkar abhiomkar changed the title Revert "fix(select): Do not fire change event on programmatic change" revert: fix(select): Do not fire change event on programmatic change Dec 3, 2019
@abhiomkar abhiomkar merged commit ad9dfe7 into master Dec 3, 2019
@abhiomkar abhiomkar deleted the revert-5255-fix/select-change branch December 3, 2019 23:13
This was referenced Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants