Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix(chips): Do not throw error if chip set becomes empty #5300

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

abhiomkar
Copy link
Collaborator

Reverts #5290

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #5300 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5300      +/-   ##
==========================================
- Coverage   98.63%   98.63%   -0.01%     
==========================================
  Files         122      122              
  Lines        5993     5991       -2     
  Branches      769      768       -1     
==========================================
- Hits         5911     5909       -2     
  Misses         81       81              
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-chips/chip-set/foundation.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f978109...719e03d. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 719e03d vs. master! 💯🎉

@abhiomkar abhiomkar changed the title Revert "fix(chips): Do not throw error if chip set becomes empty" revert: fix(chips): Do not throw error if chip set becomes empty Dec 3, 2019
@abhiomkar abhiomkar merged commit d10e8cd into master Dec 3, 2019
@abhiomkar abhiomkar deleted the revert-5290-fix/chips-empty-set branch December 3, 2019 23:15
This was referenced Feb 13, 2020
@teddywing
Copy link

@abhiomkar @patrickrodee I just experienced this issue (opened in #5275) (example: https://jsfiddle.net/e872rdm6/). Would either of you be able to clarify why the fix was reverted?

Is there an alternative that we should be using to avoid this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants