Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField fullWidth prop missing left padding with leading icon enabled #4640

Closed
dohomi opened this issue Apr 24, 2019 · 8 comments
Closed
Assignees
Labels

Comments

@dohomi
Copy link

dohomi commented Apr 24, 2019

What MDC Web Version are you using?

Latest

What browser(s) is this bug affecting?

All versions

What OS are you using?

All versions

What are the steps to reproduce the bug?

Add a leading icon to the TextField with fullwidth enabled.

What is the expected behavior?

There should be left padding on the input field to show the icon

What is the actual behavior?

Icon overlaps.

Currently I fix it with CSS

.mdc-text-field--with-leading-icon.mdc-text-field--fullwidth .mdc-text-field__input {
  padding-left: 48px !important; /* fixing misaligned input field on fullWidth TextField */
}
@moog16
Copy link
Contributor

moog16 commented Apr 26, 2019

I'm seeing this:

Screen Shot 2019-04-26 at 11 48 11 AM

Can you confirm this is also what you're seeing?

@moog16 moog16 added the backlog label Apr 29, 2019
@moog16
Copy link
Contributor

moog16 commented Apr 29, 2019

@dohomi ping :)

@dohomi
Copy link
Author

dohomi commented May 1, 2019

@moog16 thats exactly what I see as well. Fixed it with the work around above but not sure if it respects accurately Googles spec on margin/padding

@moog16
Copy link
Contributor

moog16 commented May 1, 2019

We actually don't have any guidance on this setup. We need design guidance.

@abhiomkar
Copy link
Collaborator

Design says full width text field variant can have leading / trailing icon.

Adding this to icebox.

@deleonio
Copy link

deleonio commented Feb 9, 2020

I think that this definition must be removed.

.mdc-text-field--fullwidth:not(.mdc-text-field--textarea) .mdc-text-field__input {
    padding: 0;
}

@asyncLiz
Copy link
Contributor

This will be fixed in #1892, which revamps the text field's layout.

@asyncLiz asyncLiz self-assigned this Feb 10, 2020
@asyncLiz asyncLiz added backlog and removed icebox labels Feb 10, 2020
@asyncLiz
Copy link
Contributor

asyncLiz commented Jul 7, 2020

This is obsolete since #6146 which removed the fullwidth variant

@asyncLiz asyncLiz closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants