feat(text-field): Added support for character counter. #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
reviewed
Jan 15, 2019
There was a problem hiding this comment.
I haven't gotten a chance to look at the code yet, but upon quick testing, it looks like the character counter and helper text don't line up with each other vertically.
I also sent some questions to our designer which I've CC'd you on which may have bearing on this PR.
kfranqueiro
suggested changes
Jan 15, 2019
packages/mdc-textfield/character-counter/mdc-text-field-character-counter.scss
Outdated
Show resolved
Hide resolved
packages/mdc-textfield/character-counter/mdc-text-field-character-counter.scss
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4244 +/- ##
==========================================
+ Coverage 98.4% 98.48% +0.08%
==========================================
Files 127 130 +3
Lines 5688 5736 +48
Branches 757 766 +9
==========================================
+ Hits 5597 5649 +52
+ Misses 91 87 -4
Continue to review full report at Codecov.
|
…t for text field foundation
kfranqueiro
suggested changes
Jan 25, 2019
kfranqueiro
approved these changes
Jan 29, 2019
...screenshot/spec/mdc-textfield/classes/baseline-helper-text-persistent-character-counter.html
Show resolved
Hide resolved
test/screenshot/spec/mdc-textfield/classes/baseline-helper-text-persistent-validation-msg.html
Outdated
Show resolved
Hide resolved
…o feat/textfield_char_counter
…o feat/textfield_char_counter
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for character counter that displays the ratio of characters used and the total character limit.
Character counter is added as subcomponent of text field (similar to
helper-text) which can be rendered insidehelper-textsubcomponent or insidemdc-text-fieldroot for multi-line text field (textarea).Single-line text field
New helper class
mdc-text-field-helper-lineis introduced to render two subcomponents -helper-textandcharacter-counterin a flexbox. These two subcomponents are optional.Multi-line text field
Character counter subcomponent can be independently used and is rendered inside
mdc-text-fieldroot as first element. Text field leaves a space at the bottom of textarea for character counter using sibling selector (.mdc-text-field-character-counter + .mdc-text-field__input) only for multi-line text field (textarea) variant.Fixes #13.
BREAKING CHANGE: Changed the layout of MDCTextField's
helper-textto add support for character counter feature.