feat(chips): Move logic for calculating chip bounding rect into a foundation method #4243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4243 +/- ##
=========================================
Coverage ? 98.58%
=========================================
Files ? 127
Lines ? 5705
Branches ? 762
=========================================
Hits ? 5624
Misses ? 81
Partials ? 0
Continue to review full report at Codecov.
|
|
All 758 screenshot tests passed for commit eba9a1d vs. |
| computeBoundingRect() { | ||
| // When a chip has a checkmark and not a leading icon, the bounding rect changes in size depending on the current | ||
| // size of the checkmark. | ||
| if (!this.adapter_.hasLeadingIcon() && this.adapter_.getCheckmarkBoundingClientRect()) { |
There was a problem hiding this comment.
this.adapter.getCheckmarkBoundingClientRect() returns an object...I think it is more precise to check that the function call returns an object, instead of just calling the function.
There was a problem hiding this comment.
Changed it to check to confirm it isn't null, does that work?
| @@ -60,6 +60,9 @@ class MDCChipFoundation extends MDCFoundation { | |||
| notifyRemoval: () => {}, | |||
| getComputedStyleValue: () => {}, | |||
| setStyleProperty: () => {}, | |||
| hasLeadingIcon: () => {}, | |||
| getBoundingClientRect: () => {}, | |||
There was a problem hiding this comment.
I think adding root in the method makes it more clear. getRootBoundingClientRect
packages/mdc-chips/chip/index.js
Outdated
| this.ripple_ = rippleFactory(this.root_); | ||
| } | ||
| const adapter = Object.assign(MDCRipple.createAdapter(this), { | ||
| computeBoundingRect: () => this.foundation_.computeBoundingRect(), |
There was a problem hiding this comment.
what about this.foundation_.computeBoundingRectForRipple()?
There was a problem hiding this comment.
Updated to getDimensions
|
All 758 screenshot tests passed for commit 71ffdea vs. |
|
All 758 screenshot tests passed for commit f0bdc5c vs. |
|
All 758 screenshot tests passed for commit f0bdc5c vs. |
This change makes adding ripple easier for clients wrapping chips.
BREAKING CHANGE: Adds 3 new chips adapter methods: hasLeadingIcon, getRootBoundingClientRect, and getCheckmarkBoundingClientRect. Also adds a new foundation method: getDimensions.