Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawer): Upgrade focus-trap version in drawer & dialog #4217

Merged
merged 2 commits into from
Jan 3, 2019
Merged

fix(drawer): Upgrade focus-trap version in drawer & dialog #4217

merged 2 commits into from
Jan 3, 2019

Conversation

abhiomkar
Copy link
Collaborator

@abhiomkar abhiomkar commented Jan 2, 2019 •
edited by kfranqueiro
Loading

Fixes #4104
Fixes #4131

@mdc-web-bot
Copy link
Collaborator

All 754 screenshot tests passed for commit 71cb187 vs. master! 💯🎉

@kfranqueiro
Copy link
Contributor

I got confused for a minute between #4104 and #4131. Unfortunately no release of tabbable yet contains the fix required for the latter, so we'll likely be upgrading focus-trap again in hopefully the near future...

@kfranqueiro
Copy link
Contributor

focus-trap 4.0.2 just got released along with tabbable 3.1.2, so we can upgrade again here and fix both of our issues.

@abhiomkar
Copy link
Collaborator Author

Seems like 4.0.2 was just published. Thanks for the change!

@codecov-io
Copy link

codecov-io commented Jan 2, 2019 •
edited
Loading

Codecov Report

Merging #4217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4217   +/-   ##
======================================
  Coverage    98.5%   98.5%           
======================================
  Files         127     127           
  Lines        5629    5629           
  Branches      747     747           
======================================
  Hits         5545    5545           
  Misses         84      84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a865ef5...b26f0aa. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 754 screenshot tests passed for commit b26f0aa vs. master! 💯🎉

@moog16 moog16 mentioned this pull request Jan 2, 2019
Closed
@mdc-web-bot
Copy link
Collaborator

All 754 screenshot tests passed for commit b26f0aa vs. master! 💯🎉

@abhiomkar abhiomkar merged commit ea37b07 into master Jan 3, 2019
@abhiomkar abhiomkar deleted the fix/drawer_focus_trap_upgrade_4104 branch January 3, 2019 05:46
@abhiomkar abhiomkar mentioned this pull request Jan 3, 2019
Closed
@4cm4k1 4cm4k1 mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfranqueiro kfranqueiro kfranqueiro approved these changes

@acdvorak acdvorak Awaiting requested review from acdvorak

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abhiomkar @mdc-web-bot @kfranqueiro @codecov-io @googlebot