feat(button): Add trailing icon support via label element #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
force-pushed
the
feat/button-trailing-icon
branch
from
daf8234
to
bcb6723
Compare
kfranqueiro
changed the title
This comment has been minimized.
This comment has been minimized.
kfranqueiro
force-pushed
the
feat/button-trailing-icon
branch
from
dc69eed
to
43e454a
Compare
This comment has been minimized.
This comment has been minimized.
|
🤖 Beep boop! Screenshot test report 🚦32 screenshots changed from Details24 Changed:
8 Added: |
kfranqueiro
force-pushed
the
feat/button-trailing-icon
branch
from
de7fd0b
to
43e454a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2339.
This adds support for trailing icon, using a new
mdc-button__labelelement to identify when the icon is after the label to adjust margins accordingly.This PR implements this in a non-breaking way such that existing buttons with a leading icon or no icon will be unaffected. However, it includes updates to docs and tests to encourage use of the added text label element so that we may eventually do more with it in styles. As such I'm inclined to add a breaking change note to call attention, even though this isn't actually a breaking change.
BREAKING CHANGE: We recommend placing each button's text label within a
mdc-button__labelelement. This does not immediately break existing MDC Button usage, but updating is recommended to future-proof against potential upcoming changes.