-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drawer): check for existence of ANIMATE class name in isOpening condition #4078
Conversation
All 655 screenshot tests passed for commit a3253af vs. |
Codecov Report
@@ Coverage Diff @@
## master #4078 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 126 126
Lines 5603 5603
Branches 746 747 +1
=======================================
Hits 5529 5529
Misses 74 74
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one more suggestion for tests
All 663 screenshot tests passed for commit 5bec8d2 vs. |
All 663 screenshot tests passed for commit d0bcf2b vs. |
Fixes #4049
Programmatically trigger open / close drawer in this sequence:
Before implementation:
Changed the condition of isOpening to check for existence of both
--animate
and--opening
classes to fix this.