Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): check for existence of ANIMATE class name in isOpening condition #4078

Merged
merged 5 commits into from
Nov 19, 2018

Conversation

abhiomkar
Copy link
Collaborator

Fixes #4049

Programmatically trigger open / close drawer in this sequence:

Before implementation:

drawer.open = true;
// `isOpening()` returns `false` and class name `--closing` gets added
// before `--opening` in next animation frame. This causes drawer to be
// in weird state while it is still opening.
drawer.open = false;
drawer.open = true;

Changed the condition of isOpening to check for existence of both --animate and --opening classes to fix this.

@mdc-web-bot
Copy link
Collaborator

All 655 screenshot tests passed for commit a3253af vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #4078 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4078   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files         126      126           
  Lines        5603     5603           
  Branches      746      747    +1     
=======================================
  Hits         5529     5529           
  Misses         74       74
Impacted Files Coverage Δ
packages/mdc-drawer/dismissible/foundation.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a817e58...d0bcf2b. Read the comment docs.

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one more suggestion for tests

@mdc-web-bot
Copy link
Collaborator

All 663 screenshot tests passed for commit 5bec8d2 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 663 screenshot tests passed for commit d0bcf2b vs. master! 💯🎉

@abhiomkar abhiomkar merged commit a4fd0a6 into master Nov 19, 2018
@abhiomkar abhiomkar deleted the drawer_open_close_open branch November 19, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double click on toggle icon of drawer
5 participants