fix(shape): Rename surface term with component. #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
approved these changes
Oct 15, 2018
packages/mdc-shape/README.md
Outdated
| `$mdc-shape-medium-surface-radius` | Rounded shape radius size for medium surface components. Default value `8px`. | ||
| `$mdc-shape-large-surface-radius` | Rounded shape radius size for large surface components. Default value `0`. | ||
| `$mdc-shape-small-component-radius` | Rounded shape radius size for small components. Default value `4px`. | ||
| `$mdc-shape-medium-component-radius` | Rounded shape radius size for medium components. Default value `8px`. |
There was a problem hiding this comment.
While we're here: this says 8px is the default, but it's 4px in the code.
There was a problem hiding this comment.
Good catch. Updated the docs.
|
All 557 screenshot tests passed for commit f228de5 vs. |
|
All 557 screenshot tests passed for commit 1a9b8d7 vs. |
|
All 557 screenshot tests passed for commit eba1a35 vs. |
|
All 557 screenshot tests passed for commit f26a7f8 vs. |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Renamed shape global variables from
$mdc-shape-*-surface-radiusto$mdc-shape-*-component-radius