fix(select): Fix dropdown color/opacity and options background #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
suggested changes
Sep 18, 2018
packages/mdc-select/_mixins.scss
Outdated
| @@ -147,7 +147,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| @mixin mdc-select-dd-arrow-svg-bg_($fill-hex-number: 000000, $opacity: .54) { | |||
| @mixin mdc-select-dd-arrow-svg-bg_($fill-hex-number: #000000, $opacity: .54) { | |||
| // Remove leading # from | |||
There was a problem hiding this comment.
Is this comment missing some words? Or drop "from"?
packages/mdc-select/_mixins.scss
Outdated
| @@ -147,7 +147,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| @mixin mdc-select-dd-arrow-svg-bg_($fill-hex-number: 000000, $opacity: .54) { | |||
| @mixin mdc-select-dd-arrow-svg-bg_($fill-hex-number: #000000, $opacity: .54) { | |||
There was a problem hiding this comment.
- Remove the default value for the first parameter since we always specify it
- Should the default opacity be represented in a variable? Should we also always specify that in the mixin invocation rather than providing a default? (Currently we pass 1 parameter in one invocation, and 2 parameters in the other)
| @@ -89,6 +89,8 @@ | |||
|
|
|||
| // stylelint-disable-next-line selector-max-type, plugin/selector-bem-pattern | |||
| > option { | |||
| @include mdc-theme-prop(background-color, surface); | |||
There was a problem hiding this comment.
What effect does this have on native selects?
There was a problem hiding this comment.
This causes the background-color to be the surface color on browsers that allow it. Since we're changing the color on Line 94, we also need to adjust the background-color. On browsers that don't allow modifications to the dropdown options, neither of these apply and the dropdown is rendered with a white background and black text.
kfranqueiro
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3550