Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): Change private getter method to public #3473

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

williamernest
Copy link
Contributor

Fixes an issue highlighted by the menu/drawer PR's that the get method for accessing the list elements was incorrectly added as a private method.

@mdc-web-bot
Copy link
Collaborator

All 349 screenshot tests passed for commit e64ba39 vs. master! 💯🎉

@codecov-io
Copy link

Codecov Report

Merging #3473 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3473   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         119      119           
  Lines        5021     5021           
  Branches      614      614           
=======================================
  Hits         4942     4942           
  Misses         79       79
Impacted Files Coverage Δ
packages/mdc-list/index.js 100% <100%> (ø) ⬆️
packages/mdc-menu/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453b5c5...e64ba39. Read the comment docs.

@williamernest williamernest merged commit f57c731 into master Aug 29, 2018
@williamernest williamernest deleted the fix/list/make-method-public branch August 29, 2018 22:19
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Sep 25, 2018
…s#3473)

Changes private method listElements_ to listElements.

(cherry picked from commit f57c731)
@jamesmfriedman jamesmfriedman mentioned this pull request Sep 26, 2018
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants