Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDCDrawer dynamic list items #3471

Closed
tanner0101 opened this issue Aug 29, 2018 · 2 comments
Closed

MDCDrawer dynamic list items #3471

tanner0101 opened this issue Aug 29, 2018 · 2 comments

Comments

@tanner0101
Copy link

tanner0101 commented Aug 29, 2018

When changing the list elements in an MDCDrawer after initialization, the focus behavior no longer works correctly. It is also seemingly impossible to destroy the drawer and re-initialize it succesfully (or any "relayout" function).

What MDC Web Version are you using?

"@material/drawer": "^0.39.0",

What browser(s) is this bug affecting?

Safari

What OS are you using?

High Sierra

What are the steps to reproduce the bug?

  • Initialize an MDCDrawer with list items.
  • Change the list items.
  • Observe the clicking on list items on longer correctly focuses active item.
  • Attempt to destroy / reinit the drawer.
  • Observe that the list items still no longer correctly focus active item.

What is the expected behavior?

Either MDCDrawer automatically detects re-layout, or there is a method for telling MDCDrawer that the list items have changed and it should re-initialize any necessary state.

What is the actual behavior?

MDCDrawer has no apparent way of dealing with dynamically changing list items.

Any other information you believe would be useful?

Discussed this with @moog16 in Discord. Thanks!

@williamernest
Copy link
Contributor

@tanner0101 Thanks for filing this issue. I think we resolved the list not destroying itself in v0.39.1. Can you provide a codepen reproducing your case? We're having trouble diagnosing a specific issue without a reproducible example.

Thanks!

@kfranqueiro
Copy link
Contributor

Given no further details, I'm closing this issue since we resolved the one issue we were able to identify in v0.39.1. Let us know if you still encounter problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants