Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): Add error and on-error support #3469

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

williamernest
Copy link
Contributor

@williamernest williamernest commented Aug 29, 2018

fixes: #3468
Adds error/on-error theme support.

The text field component has been updated to use the error color from the theme.

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add these to the theme README.

Also, should this PR be a feat(theme) instead of a fix(theme)?

@acdvorak acdvorak self-assigned this Aug 29, 2018
@williamernest williamernest changed the title fix(theme): Add error and on-error feat(theme): Add error and on-error support Aug 29, 2018
@mdc-web-bot
Copy link
Collaborator

All 349 screenshot tests passed for commit 02cdd27 vs. master! 💯🎉

@williamernest williamernest merged commit b10095f into master Aug 29, 2018
@williamernest williamernest deleted the fix/theme/add-error-colors branch August 29, 2018 18:02
@jamesmfriedman jamesmfriedman mentioned this pull request Sep 26, 2018
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDCTheme: Add support for error/on-error variables/classes
4 participants