fix(list): Update single line list to ellipsis #3460
Conversation
|
All 349 screenshot tests passed for commit a0b4a9f vs. |
| @@ -43,44 +43,62 @@ <h6 class="mdc-drawer__subtitle">[email protected]</h6> | |||
| <nav class="mdc-list"> | |||
| <a class="mdc-list-item mdc-list-item--activated" href="#" aria-selected="true" tabindex="0"> | |||
| <i class="material-icons mdc-list-item__graphic" aria-hidden="true">inbox</i> | |||
| Inbox | |||
| <span class="mdc-list-item__text"> | |||
There was a problem hiding this comment.
Since we restructured this can you change event.target.lastChild.textContent to event.target.lastElementChild.textContent in all drawer demos?
| <div class="mdc-list-group"> | ||
| <h3 class="mdc-list-group__subheader">List 1</h3> | ||
| <ul class="mdc-list demo-list" aria-orientation="vertical"> | ||
| <li class="mdc-list-item" tabindex="0"> |
There was a problem hiding this comment.
This block needs formatting.
packages/mdc-list/README.md
Outdated
| <li class="mdc-list-item">Single-line item</li> | ||
| <li class="mdc-list-item">Single-line item</li> | ||
| <li class="mdc-list-item"> | ||
| <span class="mdc-list-item__text"> |
There was a problem hiding this comment.
wrap this into single line?
<span class="mdc-list-item__text">Single-line item</span>
|
All 349 screenshot tests passed for commit 38e6c72 vs. |
demos/drawer/modal-drawer.html
Outdated
| @@ -215,7 +215,12 @@ <h1 class="mdc-typography--headline4">Modal Drawer</h1> | |||
| var mainEl = document.querySelector('.demo-main'); | |||
| listEl.addEventListener('click', function(event) { | |||
| drawer.open = false; | |||
| selectedDestinationEl.textContent = event.target.lastChild.textContent; | |||
| let listItemTarget = event.target; | |||
There was a problem hiding this comment.
Suggestion: if we can set pointer-events: none styles to list-item__text I believe we wouldn't we wouldn't have to do this.
Same for mdc-menu.
williamernest
force-pushed
the
fix/list/single-line
branch
from
64ec29e
to
38e6c72
Compare
|
All 349 screenshot tests passed for commit 64ec29e vs. |
Codecov Report
@@ Coverage Diff @@
## master #3460 +/- ##
=========================================
Coverage ? 98.42%
=========================================
Files ? 119
Lines ? 5026
Branches ? 617
=========================================
Hits ? 4947
Misses ? 79
Partials ? 0
Continue to review full report at Codecov.
|
|
All 349 screenshot tests passed for commit 510492e vs. |
|
All 349 screenshot tests passed for commit da0a983 vs. |
|
All 349 screenshot tests passed for commit 04be24f vs. |
) (cherry picked from commit 60cf6c5)
fixes: #3201