fix(select): Set transform origin for line ripple #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3432 +/- ##
==========================================
+ Coverage 98.3% 98.42% +0.12%
==========================================
Files 119 119
Lines 5010 5020 +10
Branches 613 613
==========================================
+ Hits 4925 4941 +16
+ Misses 85 79 -6
Continue to review full report at Codecov.
|
|
All 349 screenshot tests passed for commit 02d19dc vs. |
|
All 349 screenshot tests passed for commit 50dd4ee vs. |
|
All 349 screenshot tests passed for commit 77f2470 vs. |
kfranqueiro
approved these changes
Aug 28, 2018
packages/mdc-select/index.js
Outdated
| */ | ||
| setTransformOrigin_(evt) { | ||
| const targetClientRect = evt.target.getBoundingClientRect(); | ||
| const xCoordinates = evt.clientX; |
| @@ -366,6 +400,37 @@ test('adapter#deactivateBottomLine removes active class from the bottom line', ( | |||
| td.verify(bottomLine.deactivate()); | |||
| }); | |||
|
|
|||
| test('adapter#notchOutline proxies labelWidth and isRtl to the outline', () => { | |||
| const hasOutline = true; | |||
There was a problem hiding this comment.
Nit: Tests use hasOutline, function uses isOutline
| assert.equal(component.getDefaultFoundation().adapter_.getLabelWidth(), LABEL_WIDTH); | ||
| }); | ||
|
|
||
| test('adapter#getLabelWidth return 0 if the label does not exist', () => { |
|
All 349 screenshot tests passed for commit e7aefdb vs. |
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3159
Also adds more tests for coverage.